search

ubiquibot / comment-incentives

0 stars 10 forks source link

fix: lower than and greater than characters are escaped #37

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 1 month ago

To avoid being interpreted, < and > are escaped.

Related issue: https://github.com/ubiquity/work.ubq.fi/issues/47#issuecomment-2130649316

gentlementlegen commented 1 month ago

@0x4007 So I managed to run it locally, and this is the result I get:

image

The yellow arrow points the escaping that happened to < and > which are still valid HTML but not interpreted as code. Result preview:

image

Displayed, but as simple characters.

0x4007 commented 1 month ago

The problem I have with this is it appears as though you rendered it on a standalone HTML page, but I want to know how GitHub comments renders it before we accept the pull.

Perhaps it would be simple to just run this on your own bot instance and see how the comment appears?

gentlementlegen commented 1 month ago

@0x4007 Ran against the problematic issue, results here: https://github.com/ubiquity/work.ubq.fi/issues/47#issuecomment-2132970001