ubiquibot / comment-incentives

0 stars 12 forks source link

update `rpc-handler` #39

Open Keyrxng opened 3 months ago

Keyrxng commented 3 months ago

This plugin is using my published package and not the official ubiquity package

zugdev commented 3 months ago

/wallet 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

ubiquity-os[bot] commented 3 months ago

+ Successfully registered wallet address
zugdev commented 3 months ago

/start

Keyrxng commented 3 months ago

/start

ubiquity-os[bot] commented 3 months ago
DeadlineWed, Aug 28, 10:48 AM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
Keyrxng commented 3 months ago

/stop

ubiquity-os[bot] commented 3 months ago
# You have been unassigned from the task
Keyrxng commented 3 months ago

@zugdev can you use the /start command again and assign this. I'm unsure why it did not assign you the first time

@gentlementlegen it's not trivial to access our worker logs is it? i.e need correct access etc

gentlementlegen commented 3 months ago

@Keyrxng Sadly no, you need to live check the logs, we do not retain them. We can consider pushing them to a db but it will be huge. Cloudflare has a log system but it's a paying feature.

Keyrxng commented 3 months ago

I see, we can only assume it was a rate limit of some kind considering my comment went through okay. If it happens again I'll make a point of implementing a core plugin logger with SB posting but this is the first time I've seen it

Dhruv245 commented 3 months ago

/start

ubiquity-os[bot] commented 3 months ago
! Please set your wallet address with the /wallet command first and try again.
Dhruv245 commented 3 months ago

/wallet 0x648a958766de4cba2C9884C3c703c40392923163

ubiquity-os[bot] commented 3 months ago

+ Successfully registered wallet address
Dhruv245 commented 3 months ago

/start

Dhruv245 commented 3 months ago

/start

ubiquity-os[bot] commented 3 months ago
DeadlineWed, Aug 28, 11:29 AM UTC
Registered Wallet 0x648a958766de4cba2C9884C3c703c40392923163
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
0x4007 commented 3 months ago

@gentlementlegen it's not trivial to access our worker logs is it? i.e need correct access etc

We just have to manually invite their Cloudflare account with read only access I believe.

gentlementlegen commented 3 months ago

@0x4007 Yes but we cannot retroactively check the logs, so in this case it would not be helpful.

gentlementlegen commented 3 months ago

@zugdev Should have been assigned and this task un-assignable in the first place. There is an issue on that regard here. @Keyrxng that would be truly appreciated that you focus on https://github.com/ubiquibot/command-start-stop/pull/19 so this case doesn't happen again.

Keyrxng commented 3 months ago

@Dhruv245 @zugdev

I don't think either PR has correctly implemented the required changes so it's first one to completion gets the reward. I will assign the PR author to the task before merging.

Where the package is used in the codebase, does anything need updated such as init values etc? If you are confident that you have made the required changes and there are no errors introduced request a review from myself please


And @gentlementlegen I will do it later tonight as I have an apt to get to shortly

zugdev commented 3 months ago

/start

ubiquity-os[bot] commented 3 months ago
DeadlineWed, Aug 28, 2:40 PM UTC
Registered Wallet 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
0x4007 commented 3 months ago

It's strange that the start command is unreliable. Perhaps we can save logs to our database as we used to for review temporarily.

0x4007 commented 2 months ago

I just realized that this is the first version of conversation rewards. We should archive this repository as it is deprecated.