search

ubolonton / emacs-module-rs

Rust binding and tools for Emacs's dynamic modules
336 stars 22 forks source link

chore: Do an explicit drop in finalize function. #30

Closed cireu closed 4 years ago

cireu commented 4 years ago

function finalize accept an GCed Lisp reference, turn it into Box and dispose it directly to trigger Drop, but IMO it's better to do an explicit drop to clarify the intention.

ubolonton commented 4 years ago

Yeah, that's a good idea. Stylistically I prefer drop without the std::mem prefix, though.

cireu commented 4 years ago

Done