Naming of method Value::make_global_ref

ubolonton / emacs-module-rs

Rust binding and tools for Emacs's dynamic modules

340 stars 22 forks source link

Open cireu opened 4 years ago

cireu commented 4 years ago

According to https://rust-lang.github.io/api-guidelines/naming.html. I think we'd better to rename make_global_ref to to_global_ref to help user discover this API. What's your opinion?

cireu commented 4 years ago

Or even into_global_ref? though Value derives Copy, but it's actually a proxy type of Emacs value, not a POD in true sense.

ubolonton commented 3 years ago

Yeah, either to_ or into_ sounds better. I'm leaning towards the former, but I'm not sure yet.