Missing dependency in useEffect hook.

ucdavis / Harvest

Harvest Farm Project Tracking Website and Mobile App

MIT License

2 stars 1 forks source link

Missing dependency in useEffect hook. #868

Open sprucely opened 1 year ago

sprucely commented 1 year ago

Including setNotification in effect's dependency list causes endless loop. Maybe the notification hook needs to wrap the returned callback in useCallback?

https://github.com/ucdavis/Harvest/blob/11853a91a563729faecb3e5105bdc16839b175f4/Harvest.Web/ClientApp/src/Projects/ProjectDetailContainer.tsx#L40C7-L64