uclahs-cds / package-moPepGen

Multi-Omics Peptide Generator
https://uclahs-cds.github.io/package-moPepGen/
GNU General Public License v2.0
6 stars 1 forks source link

Novel ORF from coding transcripts #862

Closed zhuchcn closed 8 months ago

zhuchcn commented 8 months ago

Description

Novel ORF finding is now enabled from both callNoncoding and callVariant. The ORF ID is now added to the FASTA header if it's from novel ORFs for both coding and noncoding transcripts. Example:

Canonical ORF: ENST0001.1|SNV-101-A-T|1 Novel ORF: ENST0001.1|SNV-156-C-T|ORF2|1 Noncoding novel ORF: ENST0002.1|SNV-324-T-G|ORF3|2 Novel ORF with fusion: FUSION-ENST0001.1:92-ENST0077:968|ORF1|1

Closes #659

Checklist

zhuchcn commented 8 months ago

Given that the callNoncoding now not only calls peptides from noncoding transcripts, I'm thinking of renaming it to callNovelORF, which better describes what it does, that calls peptides from novel ORFs.

lydiayliu commented 8 months ago

I like the look and sound of callNovelORF lol

Is this supported in callAltTranslation already as well?

zhuchcn commented 8 months ago

I like the look and sound of callNovelORF lol

OK I'll go ahead and rename it!

Is this supported in callAltTranslation already as well?

I didn't add this alt start finding in callAltTranslation, because I like to keep it only finding alt translation on canonical ORFs. But peptides with alt trans can be still called using callNoncoding (the new callNovelORF) with --w2f-reassignment