search

uclahs-cds / package-moPepGen

Multi-Omics Peptide Generator
https://uclahs-cds.github.io/package-moPepGen/
GNU General Public License v2.0
6 stars 1 forks source link

Update tool-Docker-action to v2.1.0 #880

Closed nwiltsie closed 1 month ago

nwiltsie commented 1 month ago

This PR updates the tool-Docker-action Action to version 2.1.0. There are a few big changes in this version:

  1. Pushing to any branch foo will build this repository's image and tag it as branch-foo. That tagged image will be removed when the branch is deleted.
  2. By default the Action will only build SemVer tags (e.g. v1.2.3-xxx). Repositories that need to use other kinds of tags (e.g. v1.2beta) can pass the optional non-semver-tags argument; doing so will build all tags that begin with v.

There are a bunch of smaller changes buried in there - you can see them all at this link.

Based on this repository's existing tags, I've determined that it does follow semantic versioning. The updated workflow therefore does not pass the non-semver-tags argument to the Action, although it can be uncommented in the future if need be.

nwiltsie commented 1 month ago

Can we keep workflow_dispatch?

Shoot, I added back in the unstable tagging logic but forgot to add workflow_dispatch. I'll fix that up.

Also, is github-token no longer needed?

There is still a github-token argument, but it defaults to ${{ github.token }} so we generally don't need to provide it explicitly.

nwiltsie commented 1 month ago

Okay, I've added workflow_dispatch back in with 8e7a9946d48aa12e165f91ee6033ab43034d8815.