search

udarc / streamMedia

A website to stream media and sell them.
0 stars 1 forks source link

Peer Review Feedback #12

Closed Skfhlug closed 4 years ago

Skfhlug commented 4 years ago

Design/Code Review 3

​

Project: Stream Media

​

Developer: Jeanne D Uwimana

​

Reviewer: Suparin Fhlug

Category Criteria Rating/Comments
Project Overview
Which planned functionality has been met? Most of important functions are working good. User can add questions. Admin can add, edit, delete data from database.
What planned functionality has not been met?
Describe the GitHub history and what it demonstrates about the project progress during the semester. Jeanne is working follow the project plan. She work and commit her work 4-6 days/week
Describe how peer and instructor feedback/recommendations were incorporated into the project. It seems project is 90% done. Important parts are working fine.
Other comments/notes?
JSPs
Evaluate the JSPs for templating, business logic, data validation, overall look and feel. JSPs for this project are organized well and easy to understand. It is easy to find the code and class.
Other comments/notes?
Java code quality Evaluate the code quality for the following and identify specific areas for improvement (class, method or line number)
  • single-purpose methods
  • well-structured project
  • descriptive naming of packages, classes, methods, variables
  • classes appropriately-sized (no monster classes)
  • CPD (copy paste detection, meaning are the same lines of code repeated?)
  • are there candidates for super/subclass relationships, abstract classes, interfaces?
  • are any values hard-coded that should be in a properties file?
  • proper exception handling
  • proper error reporting to the user
  • code documentation
    		•
  • Medthods in these project are easy to understand and not too complicated.
  • The project was organized very well, easy to find classes.
  • classes, packages, methods named reasonable. It is related to the functions.
  • The classes have good size, not too small or too big. I don't see any monster classes.
  • Code are not look much different, but they are not exactly the same
  • I don't see any hard code in this project.
  • There are error pages and the validation input
  • There are no comment or code detail in some classes.
    		•  Other comments/notes?
    Logging Evaluate the use of logging, for example:
  • appropriate use of logging statements in the code for error logging and debugging
  • logging levels used - info, debug, error
  • no occurrences of System.out.printlns or printStackTrace()
  • logging works on AWS deploy
    		•
  • There are @Log4j2 in many classes
    		•  Other comments/notes?
    Unit Tests Evaluate the unit tests, for example:
  • tests are truly a unit test rather than a high level functional test
  • test data is appropriately cleaned up or handled
  • there is full coverage of methods that perform business logic or utility functions
  • redundant code is eliminated by using set up and tear down methods, i.e., @Before, @After
    		•
  • There are mathods for testing add, edit, delete, and search function.
  • There are cleanedb sql file to clean the test
  • There are tests for all entities
  • There are @BeforeEach in every classes
    		•
    Other comments/notes?
    Security Evaluate authentication/authorization:
  • There is login function for admin, and limit other user access.
    		•
    Is it implemented correctly and working locally as well as on AWS?
    Other comments/notes?
    Web Service/API integration Evaluate the service/api integration, for example:
  • Which service/api is implemented?
  • How is error handling of the service implemented? For example, what happens if the service is not available?
    		•
  • Restpi package contains pojos for External API In included
  • This project get Genre and API movie dao by Pojos
    		•
    Other comments/notes?
    Independent research topic What is the independent research topic? n/a
    Is the independent research topic/technique implemented in the project? n/a
    Other comments/notes?
    Deployment Has the application been successfully deployed to AWS? The Server is currently down
    Is the hosted application fully functioning? n/a
    Other comments/notes? n/a
    udarc commented 4 years ago

    No change was required.