Instructor Feedback - Project Checkpoint 2 - Githubissues

udarc / streamMedia

A website to stream media and sell them.

0 stars 1 forks source link

Instructor Feedback - Project Checkpoint 2 #6

Closed pawaitemadisoncollege closed 4 years ago

pawaitemadisoncollege commented 4 years ago

You've done a great job hitting, and bypassing!, the checkpoint 2 mark, so I'm going to use this time to share a couple observations:

[x] Hibernate has annotations to automatically set your timestamps. More info here: https://thoughts-on-java.org/persist-creation-update-timestamps-hibernate/
[x] I know you are still working on this, but wanted to comment here so we don't lose track of it. Read these values in from a properties file: https://github.com/udarc/streamMedia/blob/b6ba8cfd1e204d97fa2e6c8243943a82e9f0a0f9/src/main/java/com/streammedia/utility/JavaMailUtility.java#L74-L78
[x] This routing is likely to blame for the css issues you were/are seeing: https://github.com/udarc/streamMedia/blob/b6ba8cfd1e204d97fa2e6c8243943a82e9f0a0f9/src/main/java/com/streammedia/controller/FAQController.java#L31.
[x] could simplify some import statements by using . Example: https://github.com/udarc/streamMedia/blob/b6ba8cfd1e204d97fa2e6c8243943a82e9f0a0f9/src/main/java/com/streammedia/controller/FAQController.java#L2-L4 could be done in a single import `com.streammedia.entity.`

udarc commented 4 years ago

Made modifications as suggested in feedback.