search

ugermann / ssplit-cpp

Approximate reimplementation of the sentence splitter from the Moses toolkit.
Other
4 stars 9 forks source link

Windows build fixes and workflow #15

Closed XapaJIaMnu closed 3 years ago

XapaJIaMnu commented 3 years ago

Added windows build fixes and a workflow... Not sure how to run the workflow

XapaJIaMnu commented 3 years ago

@ugermann I added a windows workflow, but not sure how to add it to the actions, could you help?

ugermann commented 3 years ago

Excellent, I'd been looking into this, too, but got distracted by trying to sort out an earlier pull request by Jerin. Looks good. I'm glad you figured out the vcpkg route for getting prce2.

XapaJIaMnu commented 3 years ago

I got this to compile on my Windows environment, but I didn't manage to test the work flow (I couldn't trigger it to run). Did you manage to run it?

ugermann commented 3 years ago

Got it to run but it's currently failing. I suspect an issue with the vcpkg setup. I'm looking into this right now.

XapaJIaMnu commented 3 years ago

I don't think so. I saw something similar on the internet, and I think it's a bug with Ninja: https://github.com/raspberrypi/pico-sdk/issues/11

XapaJIaMnu commented 3 years ago

Ok, I'm able to reproduce this on my windows, but i have no idea what's happening

ugermann commented 3 years ago

Do avoid divergence, I've integrated and just pushed what I approve of in #14.