search

ugermann / ssplit-cpp

Approximate reimplementation of the sentence splitter from the Moses toolkit.
Other
4 stars 9 forks source link

automake -> cmake #16

Closed XapaJIaMnu closed 3 years ago

XapaJIaMnu commented 3 years ago

This allows windows users to take advantage of cmake for compilation. vcpkg can still be used as an option.

As for actually allowing the compilation to run on windows, we have to decide how to handle the add_subdirectory(foo) bug that ninja has.

XapaJIaMnu commented 3 years ago

This is now passes all existing checks bergamot-translator, except the windows compilation.

XapaJIaMnu commented 3 years ago

This now also allows compilation on ubuntu 16.04

XapaJIaMnu commented 3 years ago

Any idea why tests fail? They work locally...?

jerinphilip commented 3 years ago

@XapaJIaMnu not a directory output change given you changed the relative path? You'll have to edit the workflows to point to new location of executable?

XapaJIaMnu commented 3 years ago

On my manual Linux build, the output file location doesn't change.

XapaJIaMnu commented 3 years ago

@ugermann all tests pass, compiles cleanly on win32, mac, linux, can use internal and external pcre2 and works even on older ubuntu like 16.04.

ugermann commented 3 years ago

Superseded by #19