External proj cmake fixes

ugermann / ssplit-cpp

Approximate reimplementation of the sentence splitter from the Moses toolkit.

Other

4 stars 9 forks source link

External proj cmake fixes #19

Closed ugermann closed 3 years ago

ugermann commented 3 years ago

@XapaJIaMnu I've done some cleanup work. Feel free to comment on this pull request. If if looks good to you, I'll push the branch to browsermt/ssplit and create a pull request there.

Compiles on Valhalla with both g++ and clang++
Compiles on Ubuntu 20.04 with, g++, clang++, emscripten
Compiles on github runners for Mac, Windows, Ubuntu
Gets rid of dependency on ABSEIL; tough luck for anyone still insisting on C++11.

XapaJIaMnu commented 3 years ago

I guess we merge and see who screams the loudest