Cleanup, remove abseil dependency, compile on windows with Ninja - Githubissues

ugermann / ssplit-cpp

Approximate reimplementation of the sentence splitter from the Moses toolkit.

Other

4 stars 9 forks source link

Cleanup, remove abseil dependency, compile on windows with Ninja #20

Closed ugermann closed 3 years ago

ugermann commented 3 years ago

This pull request tidies up some loose ends

The dependency on abseil for string_view with obsolete compilers is eliminated.
Cleaner cmake setup.
Compiles on windows with ninja generator.
Probably compiles on Gentoo/Arch Linux out of the box with dynamic prce2 library (not tested)

Setups tested (see workflows files for most cases, except the valhalla setup):

Compiles on valhalla (Ubuntu 16.04 with cmake 3.5 and gcc 5.5 / clang 3.8).
Compiles on windows with the Ninja generator.
Compiles on the mac github runner.
Compiles on Ubuntu 20.04 with clang, g++, and emscripten for WASM compiles.