Pcre2 source compile - Githubissues

ugermann / ssplit-cpp

Approximate reimplementation of the sentence splitter from the Moses toolkit.

Other

4 stars 9 forks source link

Pcre2 source compile #8

Closed jerinphilip closed 3 years ago

jerinphilip commented 3 years ago

The mods in the diff got the compilation working on WASM. For #6. Am I missing something? I didn't have to load anything ICU, did not find a switch either in CMakeLists.txt.

Just review, don't merge. I want to rebase commits once sorted out.

/cc @abhi-agg Can you confirm?

ugermann commented 3 years ago

This didn't work for me because ARCHIVE_EXTRACT isn't available before cmake >= 3.18. I'm running Ubuntu 20.04, which ships with 3.16 apparently. In any case, I've added pcre2 as an ExternalProject, so things now work as you intended. Thanks for the inspiration. See latest version of the master branch. I've essentially pulled your branch and then made adjustments to make things work for me.