search

ui5-community / ui5-journey-recorder

Record using your UI5 app and export to wdi5 + OPA5!
https://chrome.google.com/webstore/detail/ui5-journey-recorder/clhcepeibbgcdmhalaaomdpofecmgimf
Apache License 2.0
13 stars 1 forks source link

Erroneous dependency creation for CommonPage #34

Closed wridgeu closed 1 year ago

wridgeu commented 1 year ago

Hey there,

love the extension!

I think there is a minor spelling mistake which leads to adding the wrong dependencies for the CommonPage file.

It should be matchers instead, see: https://github.com/SAP/openui5/tree/master/src/sap.ui.core/src/sap/ui/test/matchers / https://ui5.sap.com/#/entity/sap.ui.test.matchers

Here: https://github.com/ui5-community/ui5-journey-recorder/blob/781f204a1b37c72ee3d3a65f7afa69ffc242c6bc/app/src/app/scenario/codeService/strategies/opa5/CommonPageBuilder.ts#L215-L234

BR, Marco

tabris87 commented 1 year ago

Yeah, right the "s" is missing. Will fix this as soon as possible.