uic-utah / reconcile-and-post

cli to reconcile and post versions as well as create them
MIT License
1 stars 0 forks source link

deleting before reconciling and posting is BAD! #1

Closed CanDKD closed 5 years ago

CanDKD commented 5 years ago

Let's make sure that we can't run delete.bat before running reconcile.bat

steveoh commented 5 years ago

And the way to know that reconcile has been run would be by?

CanDKD commented 5 years ago

When reconcile has been run, the -RnP- versions are created. Those version don't get deleted until the delete function is run. If delete doesn't see any RnP versions then reconcile has not been run. If delete does not see RnP version then delete should fail.

I have an idea. How about a .bat called rnp_delete.bat which calls both reconcile and delete. That way delete can never be run with out first reconciling and posting.

steveoh commented 5 years ago

we can delete the delete.bat if you want but i think it is still useful

CanDKD commented 5 years ago

No, let's not delete delete.bat. I think the 'exit early if rnp versions do not exist' should cover it.