Support option overrides and test skipping

ukf / ukf-testbed

UK federation tooling testbed

Apache License 2.0

1 stars 1 forks source link

Support option overrides and test skipping #80

Closed iay closed 8 months ago

iay commented 9 months ago

WIP:

Reworked README to be clearer, and add documentation for overrides.
Supports option overrides in general based on endpoint name matching.
Supports skip: true.

alexstuart commented 9 months ago

I like this a lot & approve (in both senses of the word).

Two nits:

line 57 you typoed "imlementing"
lines 60-62 you write

v09x represents the current production deployment. Its name reflects that environment's composition: v0.9.x of the Shibboleth Metadata Aggregator, and the Xalan XSL processor included in the classpath.

You're using using x to signify "with Xalan" and also "a patch version". Might be clearer if you don't add the patch version.

iay commented 9 months ago

v09x represents the current production deployment. Its name reflects that environment's composition: v0.9.x of the Shibboleth Metadata Aggregator, and the Xalan XSL processor included in the classpath.

You're using using x to signify "with Xalan" and also "a patch version". Might be clearer if you don't add the patch version.

Oh, good catch. I will just say v0.9 in this case, and fix up the other thing. Cheers.

iay commented 9 months ago

Pushed another commit to fix those issues. I'll squash it into one of the others before merging.