search

ukf / ukf-testbed

UK federation tooling testbed
Apache License 2.0
1 stars 1 forks source link

Add Tests for check_saml2.xsl #9

Closed philsmart closed 11 months ago

philsmart commented 12 months ago 
 - Add Test: A SAML 2.0 IdP with an AttributeAuthority needs an AttributeService with an appropriate Binding
 - Add Test: Use of SAML 2.0 bindings in IdP requires SAML 2.0 in protocolSupportEnumeration.
 - Add Test: Use of SAML 2.0 bindings in AttributeAuthorityDescriptor requires SAML 2.0 in protocolSupportEnumeration
 - Add Test: Use of SAML 2.0 bindings in SP descriptor requires SAML 2.0 in protocolSupportEnumeration.
 - Add Test: It does not make sense for an IdP to have more than one SingleSignOnService with any of a list of SAML 2.0 front-channel bindings.

See also ukfederation#383

philsmart commented 12 months ago

Also added test: Add Test: Use of SAML 2.0 bindings requires SAML 2.0 in protocolSupportEnumeration.

philsmart commented 12 months ago

Also added test: Add Test: Use of SAML 2.0 bindings in AttributeAuthorityDescriptor requires SAML 2.0 in protocolSupportEnumeration

philsmart commented 12 months ago

I am going to force push these as a single commit. I will also cleanup some of the test names in the process

philsmart commented 11 months ago

I removed the PII from these tests (see #10 ). I have a commit which can remove it from the other tests as well, but I will wait for this to be checked first.

philsmart commented 11 months ago

That makes perfect sense to me. I will write that down into a wiki page when I get a chance. I did not do something like that originally because I did not want to submit something that failed. But I see what your saying, and we can then squash down (or similar) once the review is complete.

philsmart commented 11 months ago

I've split into two commits for adding the tests then fixing the XSL file.