search

ukf / ukf-testbed

UK federation tooling testbed
Apache License 2.0
1 stars 1 forks source link

Refactor inheritance and overlays #96

Closed iay closed 3 months ago

iay commented 4 months ago

Resolves #95.

iay commented 3 months ago

The tests have been successfully executed on that branch. I am probably going to have to update the Wiki page that describes the context imports: https://github.com/ukf/ukf-testbed/wiki/Bean-Contexts

Yes, sorry about that. The overall structure of contexts is the same, but the bean definition is broken up in different ways and into more files in general. There's much more emphasis on the beans coming from the parent context (defined in common-beans and validation-beans) rather than the ones defined in the validator context itself (defined in default-validator-beans and friends) to give us that guarantee of what we're testing that we wanted.

There's some scope to improve that further. At present, the parent context only imports common-beans (which imports some other things including validation-beans) but you can see that there's an application property to specify that, and it could include ukf-beans as well. There's not a huge benefit to this in the current situation, but if we had more validator contexts it would allow them to share beans.

iay commented 3 months ago

I think this is done, or at least done enough that we can merge it. @philsmart can you cast your eye over it one more time before I do that?

philsmart commented 3 months ago

I am good with this. Also, I tested the latest again and it all passes.