search

ukgovdatascience / rap-website

Website of the Reproducible Analytical Pipelines community
https://ukgovdatascience.github.io/rap-website/
8 stars 11 forks source link

Only try to decrypt the deploy key when deploying #15

Closed willbowditch closed 5 years ago

willbowditch commented 5 years ago

Just noticed that:

Pull requests sent from forked repositories do not have access to encrypted variables or data even if these are defined in the fork source project.

So PR builds will fail, even if everything is fine, when coming from a forked repo. Moving the decryption of the ssh key into the _deploy.sh script, that only runs on the master branch, should fix this.

nacnudus commented 5 years ago

Thanks! If this works, the guidance will also need updating -- I'm sure you're on top of that, just noting it here to stop me forgetting. https://ukgovdatascience.github.io/rap-website/article-deployment-ci-with-travis.html