search

ulsdevteam / islandora_solution_pack_playlist

An Islandora module to handle playlists of Audio/Video/Oral Histories
GNU General Public License v3.0
0 stars 0 forks source link

Playlist links break after Drupal upgrade #1

Open ctgraham opened 4 months ago

ctgraham commented 4 months ago

The Playlist uses a javascript: protocol to execute:

https://github.com/ulsdevteam/islandora_solution_pack_playlist/blob/8941797df7b02f11b7f15b5472939735b276ee13/includes/utilities.inc#L65

But Drupal now disallows this protocol in the l() function:

https://api.drupal.org/api/drupal/includes%21common.inc/function/l/7.x

via drupal_strip_dangerous_protocols():

https://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_strip_dangerous_protocols/7.x

ctgraham commented 4 months ago

The best approach might be to use the #attribute of l() to formulate an onClick. Quickest is to just manually form the a tag.