search

umee-network / umee

A Golang implementation of the Umee network, a decentralized universal capital facility in the Cosmos ecosystem.
Apache License 2.0
224 stars 170 forks source link

chore(auction): return error on Not Found auction ID #2544

Closed robert-zaremba closed 5 months ago

robert-zaremba commented 5 months ago

Description

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

The recent changes in the x/auction/keeper/grpc_query.go file involve enhancing the error handling in the RewardsAuction function. Specifically, the function now checks for nil rewards and returns an appropriate error if rewards are not found. Additionally, necessary imports for gRPC status codes and error handling have been added to support these improvements.

Changes

Files Change Summary
x/auction/keeper/grpc_query.go Added imports for gRPC status codes and refactored RewardsAuction function to handle nil rewards and return errors if rewards are not found.

Poem

In the code where auctions play,
Rewards and bids now find their way.
With gRPC's guiding light,
Errors handled, clear and bright.
A rabbit's joy in every line,
Making auctions run just fine. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.76%. Comparing base (7f05ad4) to head (69f9877). Report is 494 commits behind head on main.

:exclamation: Current head 69f9877 differs from pull request most recent head fde43f9

Please upload reports for the commit fde43f9 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/umee-network/umee/pull/2544/graphs/tree.svg?width=650&height=150&src=pr&token=26MOHDPL5B&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)](https://app.codecov.io/gh/umee-network/umee/pull/2544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) ```diff @@ Coverage Diff @@ ## main #2544 +/- ## =========================================== - Coverage 75.38% 62.76% -12.63% =========================================== Files 100 275 +175 Lines 8025 15946 +7921 =========================================== + Hits 6050 10009 +3959 - Misses 1589 5163 +3574 - Partials 386 774 +388 ``` | [Files](https://app.codecov.io/gh/umee-network/umee/pull/2544?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) | Coverage Δ | | |---|---|---| | [x/auction/keeper/grpc\_query.go](https://app.codecov.io/gh/umee-network/umee/pull/2544?src=pr&el=tree&filepath=x%2Fauction%2Fkeeper%2Fgrpc_query.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network#diff-eC9hdWN0aW9uL2tlZXBlci9ncnBjX3F1ZXJ5Lmdv) | `0.00% <0.00%> (ø)` | | ... and [238 files with indirect coverage changes](https://app.codecov.io/gh/umee-network/umee/pull/2544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)