umee-network / umee

A Golang implementation of the Umee network, a decentralized universal capital facility in the Cosmos ecosystem.
Apache License 2.0
224 stars 170 forks source link

chore: adding events to msg bid txn #2570

Closed gsk967 closed 4 months ago

gsk967 commented 4 months ago

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate limit exceeded

@gsk967 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 0 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 0c0f8026eb9f04a4c1fbbfc2cf360b3d71987f4f and 1f072b1cf57dbb17331a86e77b7aa5d92760821a.

Walkthrough

A new message EventRewardsBid has been added to the Umee auction module to capture events when users place bids on auction rewards. Additionally, the RewardsBid method in the msgServer struct now emits this event, providing structured details about the bids.

Changes

File(s) Change Summary
proto/umee/auction/v1/events.proto Added EventRewardsBid message to represent auction reward bids.
x/auction/keeper/msg_server.go Emitted EventRewardsBid event in the RewardsBid method.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MsgServer
    participant AuctionModule
    participant Events

    User->>MsgServer: RewardsBid(MsgRewardsBid)
    MsgServer->>AuctionModule: Process bid
    Note right of AuctionModule: Validate and handle bid
    AuctionModule->>MsgServer: Bid successful
    MsgServer->>Events: Emit EventRewardsBid(sender, id, amount)
    Events-->>User: Event notification

Poem

In the code of Umee, a change does reside,
With bids on rewards, events now abide.
Auctions made clear with each coin that's cast,
Bid with delight, an event unsurpassed.
CodeRabbit quips, in bytes we trust,
For progress and clarity, changes robust. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (7f05ad4) to head (1f072b1). Report is 513 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/umee-network/umee/pull/2570/graphs/tree.svg?width=650&height=150&src=pr&token=26MOHDPL5B&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)](https://app.codecov.io/gh/umee-network/umee/pull/2570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) ```diff @@ Coverage Diff @@ ## main #2570 +/- ## =========================================== - Coverage 75.38% 62.55% -12.84% =========================================== Files 100 275 +175 Lines 8025 16035 +8010 =========================================== + Hits 6050 10031 +3981 - Misses 1589 5231 +3642 - Partials 386 773 +387 ``` | [Files](https://app.codecov.io/gh/umee-network/umee/pull/2570?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network) | Coverage Δ | | |---|---|---| | [x/auction/keeper/msg\_server.go](https://app.codecov.io/gh/umee-network/umee/pull/2570?src=pr&el=tree&filepath=x%2Fauction%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network#diff-eC9hdWN0aW9uL2tlZXBlci9tc2dfc2VydmVyLmdv) | `0.00% <0.00%> (ø)` | | ... and [239 files with indirect coverage changes](https://app.codecov.io/gh/umee-network/umee/pull/2570/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=umee-network)