unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Integrate the new & ampersand code from scripture resources RCL into tC Create #1409

Closed birchamp closed 1 year ago

birchamp commented 2 years ago

Work on making the code for gEdit that's in the shared RCL work for tC Create - without breaking gatewayEdit.

DoD:

Ampersand can be used instead of the ellipsis for highlighting discontiguous words

elsylambert commented 1 year ago

I do not see this in translationCore Create - v1.7.1 build 179-d617b89. Has the PR been merged? @jincypjose Screenshot 2022-11-14 at 8.48.18 PM.png

jincypjose commented 1 year ago

Sorry @elsylambert just rechecked the app, version was not updated in tc Create. Now it is Build Number is 181-a4f40e9Screenshot from 2022-11-15 15-41-16.png Now the result using & is like this (orige quote- εἴ τις & εἴ τι & εἴ τις & εἴ τις)

jincypjose commented 1 year ago

As discussed with @birchamp. (its a chat from discord) jincypjose — Today at 8:31 PM I have a question for https://app.zenhub.com/workspaces/tc-create-workspace-5f049cdbfa88090016bf043e/issues/unfoldingword/tc-create-app/1409 (the issue is regarding ampersand). We just need to handle the ampersand when we type in or should all the ellipsis be replaced with ampersand? Zenhub Zenhub Zenhub | Productivity Management for Software Teams This is just to make myself clear for the issue. Birch — Today at 8:44 PM You don't need to replace the ellipsis. Just parse both the same way.

elsylambert commented 1 year ago

Blocked by #1442 as the highlighting is broken post TSV7 conversion.

elsylambert commented 1 year ago

Looks good and works fine in translationCore Create - v1.8 build 183-ca725ce. & in Original Quote is highlighted properly. Screenshot 2022-11-18 at 1.21.17 PM.png