unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

On-Open Validator broken for TSV7 files #1468

Closed elsylambert closed 1 year ago

elsylambert commented 1 year ago

The "on open" validation was intended to be a fast check of certain features to prevent it from being used, since it would likely crash tc-create. Those checks are:

Does it have the correct header? Does every row have the correct number of columns? If not report whether too few or too many. Are all ID values unique? Report all duplicates and their row numbers. It may check for:

empty rows (which would be also be a too few columns issue, but perhaps a different root cause worth reporting)

For TSV 7 files, this is broken and the app crashes when the header is bad. It does not report duplicate IDs. Screenshot 2022-12-01 at 8.46.41 AM.png

elsylambert commented 1 year ago

Looks good in translationCore Create - v1.8 build 197-7a6b5de. On-Open CV reports errors when master/target file has a bad header or duplicate id. Screenshot 2022-12-02 at 8.46.03 AM.png