search

unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Allow filtering by chapter in TSV7 #1493

Closed birchamp closed 1 year ago

birchamp commented 1 year ago

Users want to be able to filter records down to all of the records in a single chapter of a book. Now that TSV7 has a string for the reference the filter no longer has a separate chapter field; however users need to check chapter by chapter.

DoD: Users can filter to show only the records from a particular chapter.

mandolyte commented 1 year ago

This works already: Screenshot 2022-12-19 4 34 43 PM

birchamp commented 1 year ago

@mandolyte @larsgson When I do a search I get any note that includes the text '20:' because it searches all of the columns. Also the records don't show up in order for me.CleanShot 2022-12-27 at 10.35.13.png

elsylambert commented 1 year ago

translationCore Create - v1.9.0 build 211-463611d. @abelpz The max limit to show the chapter verse is 18 and we cannot scroll beyond that. Screenshot 2023-01-10 at 9.55.53 AM.png

abelpz commented 1 year ago

Thanks for finding this @elsylambert. I'll take a look

abelpz commented 1 year ago

@elsylambert this PR should fix that https://github.com/unfoldingWord/tc-create-app/pull/1510 @Joel-C-Johnson could you review it?

elsylambert commented 1 year ago

Looks good in translationCore Create - v1.9.0 build 213-b124b37. Scroll bar is visible for Chapter and verse drop-downs. The selection from the filter and display of results are showing no delay. Works fine.