unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Filter do not reset properly when closed from the header #1522

Closed elsylambert closed 1 year ago

elsylambert commented 1 year ago

When results from the filter is closed by clicking on the close button x on the header, it shows results for verse 2 and if done once again, it leaves the Reference in the header. image.png image.png

elsylambert commented 1 year ago

@abelpz I wrote this issue for the filter issue Rich saw.

elsylambert commented 1 year ago

@superdav42 Is this ready to be tested in translationCore Create - v1.10 build 218-8325097?

superdav42 commented 1 year ago

@superdav42 Is this ready to be tested in translationCore Create - v1.10 build 218-8325097?

Yes.

elsylambert commented 1 year ago

Verified in translationCore Create - v1.10 build 218-8325097. The problem is still happening. Closing the filter from the header leaves it on verse 2.

superdav42 commented 1 year ago

Can you provide more details? It seems to work fine for me. I just tested on https://develop--tc-create-app.netlify.app/ . Click the 'x' in the chip clears the filter and shows everything again. The Reset button also works as does the 'x' in each filter field. What do you do exactly to reproduce this?

elsylambert commented 1 year ago

Here is the screen recording: https://images.zenhubusercontent.com/191973535/d4c8b34e-8867-4e1a-8d2c-5311b87968f1/screen_recording_2023_02_07_at_3_42_21_pm.mov

elsylambert commented 1 year ago

https://images.zenhubusercontent.com/191973535/b823e846-8733-49b5-a051-9a5d49dc8944/screen_recording_2023_02_07_at_3_42_21_pm.mov

abelpz commented 1 year ago

@elsylambert, yes, you can assign this to me. This needs to be changed directly in tc-create. There is a bible-reference-range update that just came out, I needed it to improve the filter. Should be a simple task.

elsylambert commented 1 year ago

This is the screenshot from Daniel. When he tried to close the filter, the app crashed with a grey screen.

image.png

danielklapp commented 1 year ago

I was using Safari when app crashed with grey screen. Then tried closing filter in Chrome and it worked.

elsylambert commented 1 year ago

Not seeing this problem in - v1.10 build 228-f43ba9b. Filters now close properly when closed from the header.