Reference is missing in Add row modal for some OT books

unfoldingWord / tc-create-app

translationCore Create

https://create.translationcore.com/

MIT License

0 stars 5 forks source link

Reference is missing in Add row modal for some OT books #1533

Closed elsylambert closed 1 year ago

elsylambert commented 1 year ago

translationCore Create - v1.10 build 218-8325097

Open Lev, Num or Jos( old testament book)>tN.
Go to any row and click + to add a new row. Note that Reference is missing from the modal. And it adds the row with empty Reference.

superdav42 commented 1 year ago

So it seems to be limited to a few OT books which have this problem so far I see it in LEV, NUM and JOS but I didn't go through them all. We can probably correct it by changing the data and not the code but I'll keep digging.

elsylambert commented 1 year ago

@abelpz I found this issue as closed. Has this been merged into Develop? I do not see a build number change and the fix is not showing in translationCore Create - v1.10 build 218-8325097 ?

abelpz commented 1 year ago

@elsylambert I believe this issue was linked to @superdav42 PR so it closed automatically after I merged.

abelpz commented 1 year ago

@elsylambert this was linked to a PR in datatable-translatable, a new version of that package should be released and a updated in tCC.

elsylambert commented 1 year ago

Looks good in v1.11 build 231-7a4c868. Reference is populated for new row modal for Exo, Lev and Num.