Closed elsylambert closed 1 year ago
Some notes...
This styleguidist demo here shows proper sorting of twl files.
In the code for the demo, you can change "twl" to "tn" and it will sort TN filenames properly.
Challenge -- where is this being invoked from tc-create itself and why isn't it using the comparer named "tsvManifestFileComparer" as shown in the example?
(edit - I needed to do a git pull to obtain later commits. the master branch has v1.10 in it after all)
More notes:
I discovered that the master branch is at v1.9
but current production is at v1.10
How did that happen?
This comparison does not shown any tc-create file changes, except package.json, yarn.lock, and build_number: https://github.com/unfoldingword/tc-create-app/compare/v1.10...unfoldingword:develop
The sorting, which I think is done in gitea-react-toolkit did not change.
This comparison claims there are no differences between v1.10 and master. https://github.com/unfoldingword/tc-create-app/compare/v1.10...unfoldingword:master
However, package.json in master has this:
$ pwd
/home/cecil/Projects/github.com/unfoldingword/tc-create-app
$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
$ head package.json
{
"name": "tc-create-app",
"homepage": "https://create.translationcore.com/",
"version": "1.9.0",
"license": "MIT",
"private": false,
"bugs": {
"url": "https://github.com/unfoldingWord/tc-create-app/issues"
},
"repository": {
But the tagged has 1.10 in its package.json:
How can this be?
@mandolyte for me master branch is in same version as it is in production
package.json in master for me is this:
$ head package.json { "name": "tc-create-app", "homepage": "https://create.translationcore.com/", "version": "1.10", "license": "MIT", "private": false, "bugs": { "url": "https://github.com/unfoldingWord/tc-create-app/issues" }, "repository": {
Not sure whats happening. last time i remember i did a version update to v1.11 for scripture rcl changes(for develop) and the changes was for the highlights
I was mistaken (see edited post above) about what was in master... still looking for the last version that worked correctly. So will now back up using the tagged releases.
Looks good in translationCore Create - v1.11 build 234-4f2cbcc. The order of books are fine now.
The order of books in en_TN in develop is not in the order. Its in Alphabetical order now.![image.png](https://images.zenhubusercontent.com/5d02efb2f425650e637abe10/7046b9be-daa5-408a-8fc8-71846031e3bc)