ID missing for new row in tn_Job

unfoldingWord / tc-create-app

translationCore Create

https://create.translationcore.com/

MIT License

0 stars 5 forks source link

ID missing for new row in tn_Job #1579

Closed elsylambert closed 11 months ago

elsylambert commented 1 year ago

https://create.translationcore.com/ translationCore Create - v1.12 build 257-de3d3b0

When a new row is added in tn_Job.tsv in unfoldingWord org, the ids are not generated automatically. Screenshot 2023-05-16 at 12.17.48 PM.png

Screenshot 2023-05-16 at 12.17.37 PM.png

abelpz commented 1 year ago

I am able to reproduce this now. Will make further tests.

abelpz commented 1 year ago

The reason for this was an ID containing a wrong character. The note with ID "vrq5" contains a whitespace in it ("vrq5 ") which breaks the ID generation algorithm. @elsylambert @birchamp

birchamp commented 1 year ago

it's important to confirm that there is content in the ID but there should not be any whitespace. @jincypjose

abelpz commented 1 year ago

@birchamp @elsylambert this should be fixed by PR #1589 by @jincypjose to test this:

No ID:

try to create a new row on a tNote by clicking the + button on an existing row.
on the New row dialog, delete the autogenerated ID and click the ADD button.
A new id should be generated even though the field was blank, on the newly generated row.

Whitespace:

try to create a new row on a tNote by clicking the + button on an existing row.
on the New row dialog, add whitespace in any position of the ID and click the ADD button.
The whitespace should be removed on the newly created row.

elsylambert commented 1 year ago

Looks good in translationCore Create - v1.13 build 263-b3675b2.

danielklapp commented 1 year ago

Agree that it looks good. Tested in translationCore Create - v1.13 build 263-b3675b2.