unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Highlighting breaking with Hebrew punctuation in verse ranges #1580

Closed elsylambert closed 1 year ago

elsylambert commented 1 year ago

In Deuteronomy 1:5-6, the quote was not highlighted, so I added an & in the quote and it highlighted the first quote. image.png

abelpz commented 1 year ago

The problem with this one is that the order for the ampersand separated quotes is not right to left as you would expect for hebrew. It is actually the first quote must be on the left side, and the further quote must be on the right side.

Changing that quote to this: יְהוָ֧ה אֱלֹהֵ֛י⁠נוּ דִּבֶּ֥ר אֵלֵ֖י⁠נוּ בְּ⁠חֹרֵ֣ב & מֹשֶׁ֔ה בֵּאֵ֛ר אֶת־הַ⁠תּוֹרָ֥ה הַ⁠זֹּ֖את לֵ⁠אמֹֽר׃

Would actually highlight what was intended.

abelpz commented 1 year ago

We still have to test the above in tC @jincypjose

elsylambert commented 1 year ago

Looks good and works fine in translationCore Create - v1.12 build 260-45d04f9 Screenshot 2023-06-05 at 9.40.26 AM.png

Screenshot 2023-06-05 at 9.49.13 AM.png

danielklapp commented 1 year ago

Highlighting working properly in translationCore Create - v1.12 build 260-45d04f9.

Screenshot 2023-06-06 at 12 26 01 PM