unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Move Original Language (Greek, Hebrew) text pane to the third position in the scripture pane. #1600

Open birchamp opened 11 months ago

birchamp commented 11 months ago

Users commonly have to copy from the Original scripture pain. Therefore, they want to have that pain closest to the editing fields.

Given: that the user is editing records in a TSV that is scripture based and the Original (Greek/Hebrew) text is displayed. When: the user opens the TSV file Then: the default scripture display should show the Original text as the third (rightmost) scripture text.

DoD:

The OrigL scripture pane should be the 3rd default scripture pane

Details:

OrigL pane.png

Joel-C-Johnson commented 10 months ago

When a position is set to "1" - Greek / Hebrew will be in the first position

image

Joel-C-Johnson commented 10 months ago

when the position is set to 2 or 3 the original (Greek / Hebrew) will change the column. Default zero is set to the last position.

image

Joel-C-Johnson commented 10 months ago

For testing:

https://deploy-preview-1611--tc-create-app.netlify.app/

danielklapp commented 10 months ago

Looks good to me. See the original language resource showing in the third position in the scripture pane. Tested with translationCore Create - v1.14 build 266-2dce737.

Screenshot 2023-08-29 at 12 45 34 PM
elsylambert commented 10 months ago

Verified in translationCore Create - v1.14 build 266-2dce737. Original Language is moved to third position in the scripture pane and highlighting is fine. However, I found that the highlight was breaking for multiple occurrences when occurrence was changed, written separately in #1613 in QA fail

Joel-C-Johnson commented 8 months ago

Verified in translationCore Create - v1.14 build 266-2dce737. Original Language is moved to third position in the scripture pane and highlighting is fine. However, I found that the highlight was breaking for multiple occurrences when occurrence was changed, written separately in #1613 in QA fail

For Reference : https://github.com/unfoldingWord/tc-create-app/issues/1613#issuecomment-1743209678