When removing a row it doesn't enable the save icon

unfoldingWord / tc-create-app

translationCore Create

https://create.translationcore.com/

MIT License

0 stars 5 forks source link

When removing a row it doesn't enable the save icon #1612

Open Joel-C-Johnson opened 10 months ago

Joel-C-Johnson commented 10 months ago

Summary

In tC create when we remove a row it does not make any changes in the file. It's also not enabling the save icon. We can switch to a different file as there are no changes. It should pop a window showing files are changed

DoD

when we remove a row it should enable the save icon (that means there is an edit in the file) and click save the icon it should update the file in DCS.

Joel-C-Johnson commented 10 months ago

This issue is solved. Details here https://github.com/unfoldingWord/datatable-translatable/pull/140#issue-1883225811

elsylambert commented 9 months ago

DatatableTranslatable v1.2.1. Verified in https://deploy-preview-140--datatable-translatable.netlify.app/#/DataTableWrapper. When a row is removed, Save button is enabled.

danielklapp commented 8 months ago

Agree that when deleting a row the save button is enabled. Tested with DatatableTranslatable v1.2.1.