unfoldingWord / tc-create-app

translationCore Create
https://create.translationcore.com/
MIT License
0 stars 5 forks source link

Permalinks #28

Open klappy opened 4 years ago

klappy commented 4 years ago

What do you think about addressing this during a feature like what is in the Consume App? Every navigation action yields unique query params that are copy/pasteable to navigate directly to what you are currently viewing. For example https://glts.door43.org/?rc://unfoldingword/en/tw/tit&language=fr which would take you to translate en_tw into fr_tw as you're own logged in user and write to your repo.

jag3773 commented 4 years ago

I certainly want this to happen, I would make a few implementation suggestions though...

Both of the above would pave the way for editing or translating in a group setting, possibly using the protected branch workflow (branch could be provided as an argument). So I would suggest a pattern with these possible arguments:

Note that version and branch could be separate arguments but they could also be combined into the path spec, depends on how the app will need to use it. Here are some examples:

Of course, if language is needed as a separate argument for the app then by all means include it :)

Example of including other arguments:

Not all of the underlying features alluded to above need to be built right away, but the URL pattern should be general enough to support them as they are added (e.g. patch branches, which would require several other features to fully support).

klappy commented 4 years ago

@jag3773 This could be considered prerequisite to implementing git branch workflow in place of forks.

klappy commented 4 years ago

Okay, maybe this isn't a blocker to branch/edit workflow #61.

jag3773 commented 4 years ago

@birchamp @klappy

Note that this could be a prerequisite or at least aid book package support (no issue yet). If the book code could be passed in the URL then we'd be able to trickle that down to the components to instruct them to only load resources for that book (potentially).

BincyJ commented 4 years ago

Needed for Book Package Flow