Open klappy opened 4 years ago
I certainly want this to happen, I would make a few implementation suggestions though...
Both of the above would pave the way for editing or translating in a group setting, possibly using the protected branch workflow (branch could be provided as an argument). So I would suggest a pattern with these possible arguments:
source
: refers to the original user-or-org/repo/versiontarget
: refers to the user-or-org/repo/branch that work is going intoNote that version
and branch
could be separate arguments but they could also be combined into the path spec, depends on how the app will need to use it. Here are some examples:
/?source=unfoldingword/en_tw&target=unfoldingword/en_tw
(source and target the same, target branch defaults to master
) /?source=unfoldingword/en_tw&target=unfoldingword/en_tw/jag3773-glts-patch-1
(source and target the same, target branch set to username plus patch)/?source=unfoldingword/en_tw/v11&target=jag3773/fr_tw/
(source is version 11 of uW's en_tw and target is another user's master branch)/?source=unfoldingword/en_tw/v11&target=translation_org/fr_tw/jag3773-glts-patch-1
(a translation organization has multiple translators working from uW's en_tw version 11 and they are using patch branches to manage merges into master)Of course, if language
is needed as a separate argument for the app then by all means include it :)
Example of including other arguments:
/?source=unfoldingword/en_tw/&version=v11&target=translation_org/fr_tw&branch=jag3773-glts-patch-1&language=fr
Not all of the underlying features alluded to above need to be built right away, but the URL pattern should be general enough to support them as they are added (e.g. patch branches, which would require several other features to fully support).
@jag3773 This could be considered prerequisite to implementing git branch workflow in place of forks.
Okay, maybe this isn't a blocker to branch/edit workflow #61.
@birchamp @klappy
Note that this could be a prerequisite or at least aid book package support (no issue yet). If the book code could be passed in the URL then we'd be able to trickle that down to the components to instruct them to only load resources for that book (potentially).
Needed for Book Package Flow
What do you think about addressing this during a feature like what is in the Consume App? Every navigation action yields unique query params that are copy/pasteable to navigate directly to what you are currently viewing. For example https://glts.door43.org/?rc://unfoldingword/en/tw/tit&language=fr which would take you to translate en_tw into fr_tw as you're own logged in user and write to your repo.