build: Improve pkgconf usage

orbea commented 2 years ago

This makes it so that pkg-config is not hardcoded, many distros are now using pkgconf and people who are cross compiling may want to specify what wrapper script or pkgconf personality they wish to use by setting the PKGCONF environment variable.
This makes it so that the dependency checks are more fine grained which can be useful in case someone wants to override any of them by setting CFLAGS_FOO or LIBS_FOO accordingly.
I changed it to use the GNU make shell feature which allows only using pkg-config once per command rather than every compiled file which is significantly faster. This makefile already used the GNU make ifeq so that should not be an issue.

orbea commented 2 years ago

Not sure what the Travis osx wants for this to work or that its related to this PR, missing dependencies?

orbea commented 2 years ago

@unknownbrackets When you have time I would appreciate a review, thanks!

unknownbrackets commented 2 years ago

Sorry, I requeued the Travis check and must've somehow lost the thread.

-[Unknown]

orbea commented 2 years ago

No worries and thanks for the review.

unknownbrackets / maxcso