Closed orbea closed 2 years ago
Not sure what the Travis osx wants for this to work or that its related to this PR, missing dependencies?
@unknownbrackets When you have time I would appreciate a review, thanks!
Sorry, I requeued the Travis check and must've somehow lost the thread.
-[Unknown]
No worries and thanks for the review.
pkg-config
is not hardcoded, many distros are now usingpkgconf
and people who are cross compiling may want to specify what wrapper script or pkgconf personality they wish to use by setting thePKGCONF
environment variable.CFLAGS_FOO
orLIBS_FOO
accordingly.pkg-config
once per command rather than every compiled file which is significantly faster. This makefile already used the GNU makeifeq
so that should not be an issue.