search

unraed / DialogueTree

A free dialogue plugin for Unreal Engine 5
MIT License
23 stars 7 forks source link

CommonUI incompatibility #2

Closed saim80 closed 1 month ago

saim80 commented 6 months ago

How to Reproduce

  1. Build dialogue display widget with CommonUI components such as CommonTextBlock.
  2. Set project settings to use the new dialogue display widget.
  3. Quit and relaunch the Unreal Editor.
  4. Observe crash due to Class loading failure.

Due to the fact that UDialogueSettings uses TSubclassOf<...> for both dialogue controller and dialogue widget type variables, the mentioned classes are being directly loaded although CommonUI module is not loaded yet.

Possible Solution

I fixed the issue by replacing TSubclassOf<...> to TSoftClassPtr<...> for my local copy.

unraed commented 6 months ago

Hi Sangwoo,

Thanks for reaching out to let me know about this. I had no idea there was an incompatibility here, but I'll get it patched with the next update. Thanks again!

Best, Zach (Unraed)

On Tue, May 7, 2024 at 6:00 PM Sangwoo Im @.***> wrote:

How to Reproduce

  1. Build dialogue display widget with CommonUI components such as CommonTextBlock.
  2. Set project settings to use the new dialogue display widget.
  3. Quit and relaunch the Unreal Editor.
  4. Observe crash due to Class loading failure.

Due to the fact that UDialogueSettings uses TSubclassOf<...> for both dialogue controller and dialogue widget type variables, the mentioned classes are being directly loaded although CommonUI module is not loaded yet. Possible Solution

I fixed the issue by replacing TSubclassOf<...> to TSoftClassPtr<...> for my local copy.

— Reply to this email directly, view it on GitHub https://github.com/unraed/DialogueTree/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCMTEOFXKAU42EADN27ARWDZBFFG7AVCNFSM6AAAAABHLZWIR2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DIMRZHAZDSNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

saim80 commented 1 month ago

I confirmed the fix. Thanks for the update!