Closed williammartinez10 closed 12 months ago
Once the configuration files are setup, should these rules and styles also be applied?
^ @panchi64 (For example, change the filenames to match the new standard)
If setup correctly the configuration file should automatically tell the other teams that their code doesn't follow the standards. I don't know if that is what you're asking or if you want to apply those styles manually.
I meant that if i needed to apply the changes manually. Currently, in the branch "configuration-files", if the standards are not met, there are certain errors or warnings that will show up. Since this branch is based off of the main branch, it would be best to leave it as it is currently (with the errors and warnings showing up). Otherwise, if I were to change everything that is not meeting the standards, other branches that are based off of the main branch as well (before this branch was created), would have discrepancies and they wouldn't be so straight forward to merge.
Is that okay? I don't know, maybe I'm overthinking itπ
I meant that if i needed to apply the changes manually. Currently, in the branch "configuration-files", if the standards are not met, there are certain errors
Let me catch up real quick π. Do the errors come from a configuration file you've generated/created? Or is it more of a preemptive mention that errors will rise?
Yes, they come from the configuration files. This is what is currently being shown in terms of the filenames.
Goootcha π. Make a pull request with that configuration file, I'll override and directly merge it to main.
If you want to fix the errors that pop up on the Search page's code feel free to. But lets leave (for the time being) those errors to show up on other team's IDEs and for them to solve them accordingly.
I'll also let every other team know that their code should follow those standards and to publish their fixes ASAP.
Perfect, I'll make the pull request now.
The configuration file is expected to enforce:
camelCase
for variable nameskebab-case
for file namesUpperCamelCase
for components in individual .jsx files" "
for text2 spaces
per tab