search

urql-graphql / urql-devtools

A tool for monitoring and debugging urql during development
https://formidable.com/open-source/urql/docs/advanced/debugging/#devtools
MIT License
257 stars 11 forks source link

Remove truncation on the explorer view #291

Closed Rigellute closed 4 years ago

Rigellute commented 4 years ago

Closes #287

This might be a heavy handed fix (removes the trimCode function). Perhaps I lack context on why the truncation was there in the first place?

Seems like we might as well just show all the json? Unless there is a reason not too?

andyrichardson commented 4 years ago

@Rigellute thanks for this - looking at the screenshot in the issue, getting rid of truncation is a good shout!

why the truncation was there in the first place?

The truncation isn't ideal and was a fix for (#76). Ideally we would have arguments wrapping but that's a little tricky at the moment because the containing element uses a fixed height. It's not super obvious but in the meantime, the query arguments come up in the info panel when expanding a row.

andyrichardson commented 4 years ago

Non blocking - if you have a moment, we could do with renaming the fixtures here to use something other than "collapsed" for larger examples now that they're not being collapsed.

Rigellute commented 4 years ago

@andyrichardson I could rename "collapsed" to "large"?

andyrichardson commented 4 years ago

@andyrichardson I could rename "collapsed" to "large"?

@Rigellute yeah that should do it 👍

Rigellute commented 4 years ago

Updated the fixture naming 👍