search

urql-graphql / urql-devtools

A tool for monitoring and debugging urql during development
https://formidable.com/open-source/urql/docs/advanced/debugging/#devtools
MIT License
257 stars 11 forks source link

Upgrade typescript-eslint and fix new errors/warnings #296

Closed Rigellute closed 4 years ago

Rigellute commented 4 years ago

This upgrade introduced around 20 errors and 30 warnings.

The errors were mostly related to using "banned" types such as object | Function. I've fixed all the errors.

The warnings were mostly

Missing return type on function. (@typescript-eslint/explicit-module-boundary-types)

I've fixed all but one: the return type of useToolTip (which looks insane). I'm not sure what to do with this one, and want to discuss with the team.

We may want to suppress the explicit-module-boundary-types warning anyway?

Overall, I'd say this upgrade improves the code quality in general.

wgolledge commented 4 years ago

This PR breaks Electron - most likely due to the changes from:

require("electron") to import {...} from "electron"

TypeError: fs.existsSync is not a function

wgolledge commented 4 years ago

We ideally need to add a check that checks that the Netlify preview has actually managed to deploy correctly