urql-graphql / urql-devtools

A tool for monitoring and debugging urql during development
https://formidable.com/open-source/urql/docs/advanced/debugging/#devtools
MIT License
257 stars 11 forks source link

Code blocks don't clean up when code content changes #351

Closed andyrichardson closed 3 years ago

andyrichardson commented 3 years ago

About

We added async syntax highlighting to address performance issues.

That has addressed the perf issues, but it looks to have introduced a bug.

Kapture 2021-04-21 at 16 16 13

The code block cleans up on unmount, but not when the code (passed via props) changes while the component is mounted. This causes the old code to overlap with the new code.

I'm guessing the issue is due to this statement

ValGeorgiev commented 3 years ago

This will be fixed with the next release!