chore: Latest minor/patch updates and react packages updates - Githubissues

urql-graphql / urql-devtools

A tool for monitoring and debugging urql during development

https://formidable.com/open-source/urql/docs/advanced/debugging/#devtools

MIT License

257 stars 11 forks source link

chore: Latest minor/patch updates and react packages updates #353

Open ValGeorgiev opened 3 years ago

ValGeorgiev commented 3 years ago

Update all minor/patch updates of packages

Styled components did some minor changes in v5.2.0, that broke 2 of our snapshot tests. Update of snapshots is needed.

Preallocate global style placement to ensure cGS is consistently inserted at the top of the stylesheet; note that this is done in runtime order so, if you have multiple cGS that have overlapping styles, ensure they're defined in code in the sequence you would want them injected (see #3239)

Update react and react-dom packages

Enzyme is not working with react v17 yet. There is a non official adapter that is working for us, until official adapter is released

Update react-spring package

React-spring renamed or removed most of their types. See here https://aleclarson.github.io/react-spring/v9/#Revamped-types . Update the returning type of our own useFlash hook.

andyrichardson commented 3 years ago

Thanks for taking the time to do this @ValGeorgiev 🔥 Additional notes you've made help a massive amount 🚀

It looks like visual regression is working fine so I'm fairly comfortable with these changes. I'd say go ahead and merge it but if you have a short moment to try out basic user interactions (clicking around in cache/events view, triggering a request) in the full E2E (extension/standalone) - that should just ensure that event handlers are working as expected.

I'll pull your build artifact and do the same for the extension 👍