useidel / signal-desktop-fedora

fedora SPEC file for signal-desktop RPMs
GNU Affero General Public License v3.0
5 stars 2 forks source link

Build errors out with node version incompatibility. #6

Closed davidfetter closed 2 months ago

davidfetter commented 2 months ago

Is this a problem with an RPM-installed node?

rpmbuild --undefine=_disable_source_fetch -ba signal-desktop.spec 
setting SOURCE_DATE_EPOCH=1722038400
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.jwBGzo
+ umask 022
+ cd /home/shackle/rpmbuild/BUILD
++ date +%s
+ export SOURCE_DATE_EPOCH=1722035330
+ SOURCE_DATE_EPOCH=1722035330
+ git lfs install
Git LFS initialized.
+ node --version
v20.12.2
+ rm -rf Signal-Desktop-7.17.0
+ tar xfz /home/shackle/rpmbuild/SOURCES/v7.17.0.tar.gz
+ cd Signal-Desktop-7.17.0
+ sed 's#"node": "#&>=#' -i package.json
++ dirname /home/shackle/rpmbuild/BUILD
+ YARNCPATH=/home/shackle/rpmbuild
++ dirname /home/shackle/rpmbuild
+ YARNCPATH=/home/shackle
+ mkdir -p /home/shackle/.config/yarn/global/
+ cp .yarnclean /home/shackle/.config/yarn/global/
+ yarn --c
yarn install v1.22.22
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/6] Validating package.json...
error signal-desktop@7.17.0: The engine "node" is incompatible with this module. Expected version ">=20.15.0". Got "20.12.2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error: Bad exit status from /var/tmp/rpm-tmp.jwBGzo (%prep)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.jwBGzo (%prep)
useidel commented 2 months ago

Yes .. no ... kind of. The node version needed to build is not shipped with the fedora distributions in scope. There is now - again - a need to pull a more up-to-date version from an external repo. I have updated the readme here and also the build config on COPR to reflect this.

useidel commented 2 months ago

See above