userjack6880 / Open-DMARC-Analyzer

Open DMARC Analyzer is an Open Source DMARC Report Analyzer to be used with DMARC reports that have been parsed by John Levine's rrdmarc script or techsneeze's dmarcts-report-parser.
GNU General Public License v3.0
217 stars 23 forks source link

[Request]: Upgrade to PHP 8.X #72

Closed arvindjkhr closed 1 year ago

arvindjkhr commented 1 year ago

Upgrade to PHP 8.X Can we expect this can be upgraded to PHP 8.x as there are a lot of vulnerabilities in 7.x versions.

Thanks Arvind

userjack6880 commented 1 year ago

I'll look into this - at least one user that I'm closely working with don't have newer versions of PHP available (yet). I'll check compatibility and make updates as needed for my own setup.

The urgency to move past 7 at this moment is stalled due to inclusion of PHP versions with RHEL 7 and 8 and that RHEL 9 doesn't have wide adoption yet (which includes PHP 8).

userjack6880 commented 1 year ago

I've just tested it as is with php 8.2, and it seems to still work fine. Please confirm if this works for you as well and any bugs you may come across. I'll leave this issue open until the end of the month.

userjack6880 commented 1 year ago

Left it open a little too long. ;)

TheRickster365 commented 1 year ago

FYI Just got this working under Rocky9.1 PHP 8.0.27 Fixed the following syntax errors

PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 87 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 208 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 230 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 338 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/Punycode.php on line 122 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/Punycode.php on line 136

Getting the following Warnings PHP Warning: Array to string conversion in includes/functions.php on line 191 PHP Warning: Undefined array key "regrinfo" in includes/template.php on line 477 PHP Warning: Trying to access array offset on value of type null in includes/template.php on line 477

If have defined define('GEO_ENABLE', 0); print_r($geo_data) gives Array ( [rawdata] => Array ( ) [regyinfo] => Array ( [servers] => Array ( [0] => Array ( [server] => whois.arin.net [args] => n 203.34.58.14 [port] => 43 ) ) ) ) Array key is regyinfo (y) not (r) Looks like the issue is with phpwhois

Cheers Rick

userjack6880 commented 1 year ago

FYI Just got this working under Rocky9.1 PHP 8.0.27 Fixed the following syntax errors

PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 87 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 208 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 230 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/UnicodeTranscoder.php on line 338 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/Punycode.php on line 122 PHP Fatal error: Array and string offset access syntax with curly braces is no longer supported in vendor/mso/idna-convert/src/Punycode.php on line 136

Getting the following Warnings PHP Warning: Array to string conversion in includes/functions.php on line 191 PHP Warning: Undefined array key "regrinfo" in includes/template.php on line 477 PHP Warning: Trying to access array offset on value of type null in includes/template.php on line 477

If have defined define('GEO_ENABLE', 0); print_r($geo_data) gives Array ( [rawdata] => Array ( ) [regyinfo] => Array ( [servers] => Array ( [0] => Array ( [server] => whois.arin.net [args] => n 203.34.58.14 [port] => 43 ) ) ) ) Array key is regyinfo (y) not (r) Looks like the issue is with phpwhois

Cheers Rick

I've created a new bug report for this, since this is a closed ticket, but can you tell me which version of the Analyzer you are running?

userjack6880 commented 1 year ago

Regardless of the version you are using, I've identified that the issue lies with the phpwhois dependency. Please remove the jsmitty package and use the updated package by kevinoo

TheRickster365 commented 1 year ago

Thanks I'll try kevinoo's phpwhois. As for which version of anayliser, i just followed the instructions and git cloned the repo yesterday.

userjack6880 commented 1 year ago

Alright. Thanks!