usgo / online-ratings

AGA Online Ratings protocol and implementation
MIT License
23 stars 12 forks source link

linking AGA account for new user 500s #14

Closed amj closed 8 years ago

amj commented 8 years ago

steps to repro:

  1. register a new user on dev.usgo.org:8080
  2. go to profile
  3. click 'link my AGA account', enter AGA ID#
  4. get internal server error
brilee commented 8 years ago

I repro'd; no trace of the error in logs... gotta figure out how to get gunicorn to actually log the stack traces for a 500.

brilee commented 8 years ago

Didn't add the api key to the dev box's .env file, so the MM endpoint redirected me to login.

brilee commented 8 years ago

Fixed the original issues.

note to self: User linking flow is still broken; looks like there's some issues with app vs. current_app and using the extensions (this changed when I started using this pattern http://flask.pocoo.org/docs/0.10/patterns/appfactories/)

brilee commented 8 years ago

current_app stuff got fixed; waiting on an official email address to send email from

vash3g commented 8 years ago

What sort of information do you need to send email?

brilee commented 8 years ago

I mentioned this briefly to @amj

I'll need the email server host name (eg SMTP.google.com) and username/password (eg online-ratings@usgo.org /password )

vash3g commented 8 years ago

Will this only be sending out email? no expectation of reply back? Will it need to read from a mailbox?

brilee commented 8 years ago

Hmm. Managing an email inbox could get annoying, I think. We can make it no reply and add a link to the online ratings github issues page in the footer of the email.

brilee commented 8 years ago

AGA ID workflow is confirmed working, except you have to add manually add :8080 to all the URLs that are part of the flow, at the moment. That should work properly on prod when we get there.