usgo / online-ratings

AGA Online Ratings protocol and implementation
MIT License
23 stars 12 forks source link

Fix Link AGA ID email #77

Closed vash3g closed 7 years ago

vash3g commented 7 years ago

screen shot 2016-10-05 at 9 50 37 pm

Email needs to be formatted better with spacing and such. The dev.usgo.org long link should show up as something like "Click here to link your AGA account". AGA Management Site should be the AGA Membership Manager as well.

vash3g commented 7 years ago

Should Rating populate once you link your AGA ID?

brilee commented 7 years ago

Eventually, yes - @davisyoshida has already done most of the work for loading in all the AGA data. Actually, we may as well try to set that up now, just to see if it works.

In theory, what would happen is that a new Profile would be added, under the "AGA" aka "RLGS" server, which would have references to all of their aga game history.

vash3g commented 7 years ago

So once you link it should show you the AGA rating with a link to the AGAGD page for you?

brilee commented 7 years ago

That's not a bad idea, actually - it dovetails with Akita's request that we store some sort of link back to the player's profile page on OGS. Now that we have two use cases, I think it's a good idea to implement.

vash3g commented 7 years ago

Could we do that to all of the servers? IGS would be tough, but KGS and most likely OGS have a standard path with the username for the list of records.

brilee commented 7 years ago

Yes, we could. I'm trying to figure out how we might do it. One way is to have a server.user_page_template = agagd.usgo.org/player/%s/, and then for each player store a player.id_on_server = 17 and then combine the two, but this almost certainly will not work in general. So it might just have to be a URL field for each user, and OGS / KGS will have to tell us where to look. (It would be an optional feature for them to implement)