search

uulm-mrm / ros2_def

Deterministic Execution Framework for ROS 2
https://uulm-mrm.github.io/ros2_def
Apache License 2.0
9 stars 2 forks source link

`wait_until_pending_actions_complete`: docs and use in `orchestrator_rosbag_player` wrong #7

Open ottojo opened 7 months ago

ottojo commented 7 months ago

Function does not block, as specified in docs, but return a future that must be awaited: https://github.com/uulm-mrm/ros2_def/blob/develop/ros2/orchestrator/orchestrator/orchestrator_lib/orchestrator.py#L459

Incorrect use in rosbag player: https://github.com/uulm-mrm/ros2_def/blob/develop/ros2/orchestrator_rosbag_player/orchestrator_rosbag_player/rosbag_player.py#L140

Perhaps add typechecker attribute to prevent discarding return value?

@authaldo