Resolve: Refactoring/repo structur - [merged]

[fgardt]

In GitLab by @mm1398 on Nov 15, 2022, 11:45

Merges refactoring/repo-structur -> master

What this MR does / why we need it:

Updated the projektur structure from documentation

Make sure that you've checked the box below before you submit MR:

• [X] no conflict with master branch.

Which platform/language

None

Which issue this MR fixes (optional)

Closes documentation#4. Closes documentation#5.

CHANGELOG/Release Notes (optional)

/cc @Slartibartfass2

Thanks for your MR, you're awesome! :+1:

[fgardt]

In GitLab by @mm1398 on Nov 15, 2022, 11:45

requested review from @Slartibartfass2, @fgardt, and @Merseleo

[fgardt]

In GitLab by @mm1398 on Nov 15, 2022, 11:45

requested review from @Shiroen95

[fgardt]

In GitLab by @Merseleo on Nov 15, 2022, 13:04

Why all protocols folders are not grouped in a "protocols" folder? Continuing the collection of the protocols would end up in a mess of folders in the root folder, doesn't it?

[fgardt]

In GitLab by @mm1398 on Nov 18, 2022, 21:15

resolved all threads

[fgardt]

In GitLab by @mm1398 on Nov 18, 2022, 21:16

added 1 commit

• b3910a26 - refactor(protocols): moved folders in a parent folder

Compare with previous version

[fgardt]

In GitLab by @mm1398 on Nov 18, 2022, 21:17

marked this merge request as ready

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

Commented on .gitlab/merge_request_templates/Merge-request.md line 19

It's not necessary to put me in cc in MRs, so please remove this.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

Rename Merge-request.md to Default.md so that this template is automatically used when creating a new MR.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

Commented on .gitlab/merge_request_templates/Merge-request.md line 6

I think this isn't necessary as merge conflicts are automatically checked and a merge would be prevented by branch protection.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

Commented on .gitlab/merge_request_templates/Merge-request.md line 7

I would add e.g.

- [ ] Documentation (if required)
- [ ] Style guides

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

Commented on .gitlab/merge_request_templates/Merge-request.md line 10

Maybe add

- [ ] Flutter
- [ ] Android
- [ ] iOS

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:47

What's the difference between Bug-report.md and Bug-issue.md and between feature-issue.md and Feature-report.md?

[fgardt]

In GitLab by @Slartibartfass2 on Nov 19, 2022, 15:52

mentioned in merge request smart-sensing-library!1

[fgardt]

Links to the protocols would be nice

something like this (not 100% sure if those links are correct)

# Protocols
- [2022-09-21](Protocols/2022_09_21)
- [2022-10-14](Protocols/2022_10_14)
- [2022-10-20](Protocols/2022_10_20)
- [2022-10-25](Protocols/2022_10_25)
- [2022-10-30](Protocols/2022_10_30)
- [2022-11-04](Protocols/2022_11_04)

[fgardt]

not sure if the style guides checkbox is that useful

[fgardt]

we could also add all 3 label commands below and add a comment to remove the non applying labels before opening the MR.

<!--- Remove non applying label commands below -->
/label ~"target::flutter" 
/label ~"target::android" 
/label ~"target::ios" 

[fgardt]

I think the .gitkeep file can be removed from .gitlab/issue_template

[fgardt]

In GitLab by @Merseleo on Nov 22, 2022, 11:37

approved this merge request

[fgardt]

In GitLab by @mm1398 on Nov 22, 2022, 12:50

marked this merge request as draft

[fgardt]

In GitLab by @mm1398 on Nov 22, 2022, 13:15

added 1 commit

• 860542e2 - docs(Readme): added links to the Readme File

Compare with previous version

[fgardt]

In GitLab by @mm1398 on Nov 22, 2022, 13:15

resolved all threads

[fgardt]

In GitLab by @mm1398 on Nov 22, 2022, 13:15

marked this merge request as ready

[fgardt]

In GitLab by @Merseleo on Nov 22, 2022, 14:49

approved this merge request

[fgardt]

In GitLab by @Slartibartfass2 on Nov 22, 2022, 16:28

Commented on .gitlab/merge_request_templates/Merge-request.md line 7

I think it makes sense as there are style guide rules which aren't checked by a linter.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 22, 2022, 16:28

Friendly reminder to apply all the changes from https://gitlab.uni-ulm.de/se-anwendungsprojekt-22-23/documentation/-/merge_requests/1/diffs?diff_head=true to this MR.

Additionally please answer every thread so that we can resolve and merge this.

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:16

Commented on .gitlab/merge_request_templates/Merge-request.md line 19

changed this line in version 4 of the diff

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:16

Commented on .gitlab/merge_request_templates/Merge-request.md line 6

changed this line in version 4 of the diff

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:16

Commented on .gitlab/merge_request_templates/Merge-request.md line 7

changed this line in version 4 of the diff

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:16

Commented on .gitlab/merge_request_templates/Merge-request.md line 10

changed this line in version 4 of the diff

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:16

added 1 commit

• 00f231e7 - docs(templates):updated templates

Compare with previous version

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 15:39

added 1 commit

• 4020a591 - docs(Issue Tmeplate): removed /assign_reviewer @Merseleo from documentation template

Compare with previous version

[fgardt]

In GitLab by @mm1398 on Nov 24, 2022, 18:38

added 2 commits

• 400eb1e4 - docs(issue template): removed duplicated line
• 96a10d5e - docs(issue template): updated feature request template

Compare with previous version

[fgardt]

In GitLab by @Slartibartfass2 on Nov 24, 2022, 23:30

Commented on .gitlab/merge_request_templates/Merge-request.md line 7

@mm1398 What is your opinion on that?

Please answer threads.

[fgardt]

In GitLab by @Merseleo on Nov 25, 2022, 10:25

approved this merge request

[fgardt]

In GitLab by @mm1398 on Nov 25, 2022, 11:40

Commented on .gitlab/merge_request_templates/Merge-request.md line 7

I think its a good idea. I already implemented on the current version.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 25, 2022, 11:41

approved this merge request

[fgardt]

In GitLab by @Shiroen95 on Nov 25, 2022, 11:41

approved this merge request

[fgardt]

resolved all threads

[fgardt]

In GitLab by @mm1398 on Nov 25, 2022, 11:43

Alright

[fgardt]

resolved all threads

[fgardt]

I dont think gitlab has proposal_templates as a folder for specific template types. These 2 templates should probably be moved to issue_templates instead.

Also: all templates start with a capital letter except for feature-issue.md. Please change that to Feature-issue.md.

[fgardt]

In GitLab by @mm1398 on Nov 25, 2022, 12:31

added 2 commits

• bbf8489c - docs(Issue Template): renamed Proposal template and moved to isssue_template
• bc74b79f - docs(Issue Template): moved Feature request template to issue_template

Compare with previous version

[fgardt]

In GitLab by @mm1398 on Nov 25, 2022, 12:32

Alright thanks.

[fgardt]

In GitLab by @Slartibartfass2 on Nov 25, 2022, 13:25

approved this merge request

[fgardt]

still missing the rename of feature-issue.md or am I missing something?

[fgardt]

In GitLab by @Slartibartfass2 on Nov 25, 2022, 14:08

removed review request for @Merseleo, @Shiroen95, and @Slartibartfass2

[fgardt]

In GitLab by @Slartibartfass2 on Nov 25, 2022, 14:24

added 1 commit

• 53f1370d - docs(Issue Template): asserted leading upper case for issue templates

Compare with previous version

[fgardt]

In GitLab by @Slartibartfass2 on Nov 25, 2022, 14:26

Please let's get this done.

[fgardt]

resolved all threads

[fgardt]

approved this merge request