search

uvic-aero / onboard-computer

0 stars 1 forks source link

deleted files in the VideoDisplay Folder #15

Closed VarsyG closed 5 years ago

VarsyG commented 5 years ago

Looks great! Just a couple small things:

No big deal for now, but in the future, try and name your branches with a something more descriptive, deletion is a bit too general, something like remove-videodisplay would be good.

Try and run python3 obc.py and you'll get some output like this: ModuleNotFoundError: No module named 'apps.VideoDisplay'

What you're gonna wanna do is track down where this error is occurring and remove any references to VideoDisplay.

Don't hesitate to ask me (Avery) or Dragon any questions you have. Also if you don't get to it until next meeting that's okay too, we'll help you out with getting this PR merged!

I have made those changes and believe that it is working properly. Would you have another look at it?

dragonprevost commented 5 years ago

Looks good! Go ahead and merge it whenever you would like.