Renamed TelemData folder and class to Pixhawk.

logankuzyk commented 5 years ago

https://github.com/uvic-aero/onboard-computer/issues/7

Renamed TelemData and class to Pixhawk. The telemData.py file has not been renamed.

dragonprevost commented 5 years ago

Hey Logan, great work on the processes of creating a feature branch, making changes, pushing and getting used to the github workflow.

A couple things that should be updated before this gets merged into master.

Update the filename and classname
- class TelemData -> class Pixhawk
- telemData.py -> pixhawk.py
- Then update the imports accordingly

It seems that there is still an import that needs to be updated in apps/Pixhawk/routes.py.

File "/Users/dragon/aero/onboard-computer/apps/Pixhawk/routes.py", line 1, in <module>
from apps.TelemData.handlers import Status, Stop, Start
ModuleNotFoundError: No module named 'apps.TelemData.handlers'

I think you may have changed the execStart path in obc.service to match your machine here. This may have happened automatically but just make sure to change it back to what it was. Also let me know if it happened automatically because it may be an issue on other peoples machines if that is the case

Other than that everything is looking really good. It seems like you made all the changes I was expecting!

P.S. Stay hydrated and well fed!

dragonprevost commented 5 years ago

Great work @logankuzyk, this issue was bigger than I had originally intended but I am sure you have gained a good sense of how obc works now! Merge this PR whenever you have the time :)

uvic-aero / onboard-computer

Renamed TelemData folder and class to Pixhawk. #19