search

uvic-aero / onboard-computer

0 stars 1 forks source link

Deleted Tornado #20

Closed agrymaloski closed 5 years ago

agrymaloski commented 5 years ago

Deleted tornado, routes and handlers.

dragonprevost commented 5 years ago

Hey make sure you pushed the commit where you deleted all the routes and handler files, I dont think I see them in this pull request...

Other than that everything is looking really good! Just let me know once you push again!

agrymaloski commented 5 years ago

Re-tried to upload code. Should work?

dragonprevost commented 5 years ago

Re-tried to upload code. Should work? Looks like it is on there! I will take a look at everything now.

dragonprevost commented 5 years ago

Looking good to me!

I did notice that we didn't remove tornado from requirements.txt. I tried removing it and it appears that the asyncio package was bundled inside of tornado, and we're still using it in a few areas of the code. @dragonprevost Maybe we can go ahead with a merge on this one, and remove the tornado dependency in a subsequent PR?

Yeah sounds good to me, it seems that there may be some deeper digging into the async situation but that is outside the scope of this Issue...