Closed agrymaloski closed 5 years ago
Hey make sure you pushed the commit where you deleted all the routes and handler files, I dont think I see them in this pull request...
Other than that everything is looking really good! Just let me know once you push again!
Re-tried to upload code. Should work?
Re-tried to upload code. Should work? Looks like it is on there! I will take a look at everything now.
Looking good to me!
I did notice that we didn't remove
tornado
fromrequirements.txt
. I tried removing it and it appears that theasyncio
package was bundled inside of tornado, and we're still using it in a few areas of the code. @dragonprevost Maybe we can go ahead with a merge on this one, and remove the tornado dependency in a subsequent PR?
Yeah sounds good to me, it seems that there may be some deeper digging into the async situation but that is outside the scope of this Issue...
Deleted tornado, routes and handlers.